-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Specify Visual Basic versions #13361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cc @rpetrusha |
rpetrusha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @NextTurn, for submitting this PR. Many of the references, though, either are not Visual Basic 2005-specific, and in fact some of this documentation was almost certainly written for Visual Basic 2002.
@KathleenDollard, could you take a look at this PR? My recollection about when particular VB features were introduced is more than a bit murky at this point.
docs/framework/debug-trace-profile/tracing-and-instrumenting-applications.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/controls/controls-to-use-on-windows-forms.md
Outdated
Show resolved
Hide resolved
docs/standard/events/how-to-handle-multiple-events-using-event-properties.md
Outdated
Show resolved
Hide resolved
...nguage-features/objects-and-classes/object-lifetime-how-objects-are-created-and-destroyed.md
Outdated
Show resolved
Hide resolved
...nguage-features/objects-and-classes/object-lifetime-how-objects-are-created-and-destroyed.md
Outdated
Show resolved
Hide resolved
KathleenDollard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the goal of inserting 2005? I'm not sure this is the best way to achieve that.
...nguage-features/objects-and-classes/object-lifetime-how-objects-are-created-and-destroyed.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
|
Once we remove the event properties note, @NextTurn, this PR is ready to merge. Thanks for following up on it. |
|
Thanks for updating this article and making the additional changes, @NextTurn, as well as for your patience. I'll merge your PR now. |
Continued from #12251
Fixes #13356