Skip to content

Conversation

@nxtn
Copy link
Contributor

@nxtn nxtn commented Jul 12, 2019

Continued from #12251
Fixes #13356

@nxtn
Copy link
Contributor Author

nxtn commented Jul 12, 2019

/cc @rpetrusha

@nxtn nxtn marked this pull request as ready for review July 15, 2019 01:43
@nxtn nxtn requested a review from KathleenDollard as a code owner July 15, 2019 01:43
@rpetrusha rpetrusha added this to the July 2019 milestone Jul 15, 2019
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NextTurn, for submitting this PR. Many of the references, though, either are not Visual Basic 2005-specific, and in fact some of this documentation was almost certainly written for Visual Basic 2002.

@KathleenDollard, could you take a look at this PR? My recollection about when particular VB features were introduced is more than a bit murky at this point.

Copy link
Contributor

@KathleenDollard KathleenDollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the goal of inserting 2005? I'm not sure this is the best way to achieve that.

nxtn and others added 2 commits July 17, 2019 09:20
@rpetrusha
Copy link
Contributor

Once we remove the event properties note, @NextTurn, this PR is ready to merge. Thanks for following up on it.

@rpetrusha
Copy link
Contributor

Thanks for updating this article and making the additional changes, @NextTurn, as well as for your patience. I'll merge your PR now.

@rpetrusha rpetrusha merged commit a927757 into dotnet:master Aug 2, 2019
@nxtn nxtn deleted the vb branch August 2, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Event properties are not supported in Visual Basic."

3 participants